feat(storybook): choose to generate ts config #10572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
changed the title
mandarini
force-pushed
the
fix/choose-ts-storybook-config
branch
from
b620acf
to
41f9be8
Compare
mandarini
force-pushed
the
fix/choose-ts-storybook-config
branch
from
41f9be8
to
d756dc2
Compare
mandarini
force-pushed
the
fix/choose-ts-storybook-config
branch
from
d756dc2
to
a724286
Compare
mandarini
force-pushed
the
fix/choose-ts-storybook-config
branch
from
a724286
to
6825d0c
Compare
ISSUES CLOSED: nrwl#10394
mandarini
force-pushed
the
fix/choose-ts-storybook-config
branch
from
6825d0c
to
30bac82
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #10394
Current Behavior
Right now, we are generating
.jsconfiguration files for Storybook (main.js/preview.js).Expected Behavior
Allow user to choose if they want to generate TS Configuration files for Storybook (
main.ts/preview.ts).If the root configuration is in TS, then Nx will generate TS configuration for all following projects as well.
If the root configuration is in JS, and the user tries to generate TS config for some project, then they will get a warning and Nx will still generate JS config.
Here's the Storybook docs for TS configs
Related Issue(s)
Fixes #10394