Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix outputs migration #10575

Merged
merged 1 commit into from Jun 3, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Migration fails if there are no targets on a project.

Running migration 14-2-0-replace-relative-outputs-with-absolute
Cannot convert undefined or null to object
TypeError: Cannot convert undefined or null to object
    at Function.values (<anonymous>)

Expected Behavior

Migration does not fail if there are no targets on a project and formats files afterwards

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Jun 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b37fef0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jun 3, 2022 at 5:00PM (UTC)

@FrozenPandaz FrozenPandaz marked this pull request as ready for review June 3, 2022 16:57
@FrozenPandaz FrozenPandaz merged commit 41882bf into nrwl:master Jun 3, 2022
@FrozenPandaz FrozenPandaz deleted the fix-core-migration branch June 3, 2022 18:49
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant