Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): apply default eager packages correctly #10496 #10596

Merged
merged 1 commit into from Jun 6, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 6, 2022

Current Behavior

withModuleFederation is using an immutable approach to updating the shared dependencies when applying default eager packages

Expected Behavior

It should be updating by reference

Related Issue(s)

Fixes #10496

@Coly010 Coly010 self-assigned this Jun 6, 2022
@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 6, 2022 at 2:22PM (UTC)

@Coly010 Coly010 merged commit 339b129 into nrwl:master Jun 6, 2022
@Coly010 Coly010 deleted the fix-mfe-polyfills branch June 6, 2022 15:12
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate an existing angular app into a mfe host
1 participant