Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): resolve shallow dependencies when building package.json #10600

Merged
merged 1 commit into from Jun 6, 2022

Conversation

mckramer
Copy link
Contributor

@mckramer mckramer commented Jun 6, 2022

For JS builds, the dependencies are now resolved shallow, dependencies will no longer inherit deps
from other buildable libs in the workspace

Current Behavior

Dependencies are currently resolved "deep". When the buildable lib has dependencies on other buildable libs in the workspace, the dependencies from those libs would be inherited.

Expected Behavior

The dependencies should be resolved shallow.

Related Issue(s)

Fixes #9371

For JS builds, the dependencies are now resolved shallow, dependencies will no longer inherit deps
from other buildable libs in the workspace

ISSUES CLOSED: 9371
@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bf4eb5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 6, 2022 at 5:23PM (UTC)

@AgentEnder AgentEnder changed the title fix(js): resolve shallow dependencies when building fix(js): resolve shallow dependencies when building package.json Jun 6, 2022
@AgentEnder AgentEnder merged commit a0bf1f0 into nrwl:master Jun 6, 2022
@mckramer mckramer deleted the issues/9371 branch June 6, 2022 19:36
vsavkin added a commit to vsavkin/nx that referenced this pull request Jun 7, 2022
vsavkin added a commit that referenced this pull request Jun 7, 2022
@FrozenPandaz
Copy link
Collaborator

We had to revert this PR because it broke the way cypress was built within the Nx repo. Could you please take a look at why this broke and fix it?

@mckramer
Copy link
Contributor Author

@FrozenPandaz, can you clarify what the error was? I don't see any info in the revert and yarn build works fine with the commit on my machine.

@tinesoft
Copy link
Contributor

Any update on this? @vsavkin @FrozenPandaz @mckramer
I'm also having the issue this PR was attending to solve(dependencies of dependent library project wrongly included in generated package.json) ....

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS package build incorrectly includes dependencies of dependencies
4 participants