Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle paths correctly on windows when migrating angular cli workspaces to nx #10611

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 7, 2022

Current Behavior

When migrating an Angular CLI workspace to Nx in a Windows machine, some paths are not handled correctly causing the migration to not move some files. Also, some wrong warnings are being printed regarding non-existing files that actually exist.

Expected Behavior

We should be able to migrate Angular CLI workspaces to Nx in Windows machines correctly. No invalid warnings should be printed.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 June 7, 2022 11:17
@leosvelperez leosvelperez self-assigned this Jun 7, 2022
@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 7, 2022 at 11:17AM (UTC)

@leosvelperez leosvelperez changed the title fix(angular): handle paths correctly on window when migrating angular cli workspaces to nx fix(angular): handle paths correctly on windows when migrating angular cli workspaces to nx Jun 7, 2022
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit f828da9 into nrwl:master Jun 7, 2022
@leosvelperez leosvelperez deleted the angular/fix-ng-add-paths-window branch June 7, 2022 12:26
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants