Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): support secondary entry points #10329 #10615

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 7, 2022

Current Behavior

Secondary entrypoints are not shared correctly for workspace libraries.

Expected Behavior

We should share secondary entrypoints for workspace libraries correctly

Related Issue(s)

Fixes #10329

@Coly010 Coly010 requested a review from leosvelperez June 7, 2022 15:11
@Coly010 Coly010 self-assigned this Jun 7, 2022
@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 9, 2022 at 8:58AM (UTC)

@Coly010 Coly010 marked this pull request as ready for review June 8, 2022 08:24
@Coly010 Coly010 force-pushed the module-federation-workspace-secondary-entry branch 3 times, most recently from 995f1b8 to 306c61b Compare June 9, 2022 08:18
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

e2e/angular-core/src/projects.test.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the module-federation-workspace-secondary-entry branch from 306c61b to 448b140 Compare June 9, 2022 08:58
@Coly010 Coly010 enabled auto-merge (squash) June 9, 2022 09:00
@Coly010 Coly010 merged commit 67a2777 into nrwl:master Jun 9, 2022
@Coly010 Coly010 deleted the module-federation-workspace-secondary-entry branch June 9, 2022 09:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants