Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): generator and executor generators should work in js libs #10621

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Jun 7, 2022

Current Behavior

nx g @nrwl/nx-plugin:generator and nx g @nrwl/nx-plugin:executor have hardcoded paths for generators.json / executors.json with fallbacks in place for angular-CLI named collections.

They also fail if there is no executors.json or generators.json collection present. This is different from the behavior of @nrwl/nx-plugin:migration, so it is corrected in this PR.

Expected Behavior

nx g @nrwl/nx-plugin:generator and nx g @nrwl/nx-plugin:executor read paths for collection files from package.json and create them if they are not present

Related Issue(s)

Community slack thread: https://nrwlcommunity.slack.com/...

Fixes #

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 7, 2022 at 7:31PM (UTC)

@AgentEnder AgentEnder force-pushed the fix/generator-and-executor-generators-should-work-in-js-libs branch from 52c8e00 to bad9704 Compare June 7, 2022 19:31
@AgentEnder AgentEnder merged commit 8fc70ce into nrwl:master Jun 7, 2022
@AgentEnder AgentEnder deleted the fix/generator-and-executor-generators-should-work-in-js-libs branch June 7, 2022 20:00
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants