Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): prevent deleting library's root package.json file on windows machines #10635

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The migration to remove library secondary entry points' package.json files deletes the package.json at the root of the library when using Windows.

Expected Behavior

The migration to remove library secondary entry points' package.json files should not delete the package.json at the root of the library.

Related Issue(s)

Fixes #10626

@leosvelperez leosvelperez requested a review from Coly010 June 8, 2022 10:31
@leosvelperez leosvelperez self-assigned this Jun 8, 2022
@vercel
Copy link

vercel bot commented Jun 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 8, 2022 at 10:32AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 9e91baf into nrwl:master Jun 8, 2022
@leosvelperez leosvelperez deleted the angular/migration-normalize-path branch June 8, 2022 10:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failes after upgrade to v14.2.1
2 participants