Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): set migration to use nx cli #10638

Merged
merged 1 commit into from Jun 8, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

The update-external-emotion-jsx-runtime-14.1.0 migration doesn't have the cli set to nx. This causes the migration to be run with the Angular CLI which might not be available in workspaces where Angular is not used.

Expected Behavior

The update-external-emotion-jsx-runtime-14.1.0 migration should use the Nx CLI.

Related Issue(s)

Fixes #10628

@leosvelperez leosvelperez self-assigned this Jun 8, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 17b93ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 8, 2022 at 1:01PM (UTC)

@leosvelperez leosvelperez requested a review from jaysoo June 8, 2022 13:01
@leosvelperez leosvelperez merged commit a1f3e0e into nrwl:master Jun 8, 2022
@leosvelperez leosvelperez deleted the react/fix-migration branch June 8, 2022 13:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot migrate to v14.2.1
1 participant