fix(js): check that project's package.json exists before attempting to read its contents

[adriangroch]

ISSUES CLOSED: #10649

Current Behavior

Building a node application using @nrwl/js:tsc as the executor without a package.json within the applications folder causes an error to be thrown as the executor attempts to read the contents file that does not exist.

Expected Behavior

An error is not thrown as we now check that the file exists before attempting to update it.

Related Issue(s)

Fixes #10649

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9efd349. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=build --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0 --parallel=3
• nx affected --target=e2e --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0 --parallel=3
• nx affected --target=test --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0 --parallel=1
• nx build typedoc-theme
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=99b245b08d918e335562551dbd277f9fb2e9706a --head=9efd349c84714f6ad7664959a2879be344c9e6d0
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Jun 9, 2022 at 11:09PM (UTC)

[AgentEnder]

This looks good, thanks for the contribution 🎉.

I left a few comments, after those are fixed we should be able to merge this.

[AgentEnder]

Hey @adriangroch! Sorry, I shouldn't have reviewed this so late at night evidently 😅. We should move the fileExists check inside of the updatePackageJson function s.t. the correct package.json still gets generated inside the dist folder.

I'd recommend moving it there, and doing something like:

const packageJson = fileExists(pathToPackageJson) ? readJson(pathToPackageJson) : {name: context.projectName}

This will also fix the same issue for @nrwl/js:swc.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.