Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): better webpack5 detection logging #10662

Merged

Conversation

mandarini
Copy link
Member

ISSUES CLOSED: #10585, #9290

Current Behavior

webpack5 detection regex is not accurate and creates issues and confusion

Expected Behavior

make the webpack5 detection more accurate and provide better logging

Related Issue(s)

Fixes #9290, #10585

@mandarini mandarini self-assigned this Jun 9, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 593940f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 9, 2022 at 2:03PM (UTC)

@mandarini mandarini enabled auto-merge (squash) June 9, 2022 14:03
@mandarini mandarini merged commit e29cd09 into nrwl:master Jun 9, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Storybook custom builder RegExp for builder webpack5 for storybook not recognized properly
1 participant