Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): update nx generator commands in react sample app #10680

Merged
merged 1 commit into from Jun 10, 2022

Conversation

damian66
Copy link
Contributor

Current Behavior

Sample application generated with @nrwl/react contains a Next Steps section with @nrwl/angular commands. See the screenshot below.

Screenshot 2022-06-10 at 13 26 01

Expected Behavior

Sample application generated with @nrwl/react should contain a valid next steps documentation to be accurate, easy to understand.

Question - I was not sure if I should include another command as an example for first steps so decided to add a single commit with a fix and discuss that further. Should Next Steps include also a command for generating react hooks?
https://nx.dev/packages/react#creating-hooks

@nx-cloud
Copy link

nx-cloud bot commented Jun 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 994aa48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 10, 2022 at 11:37AM (UTC)

@damian66 damian66 changed the title fix(react): updated nx generator commands in react sample app fix(react): update nx generator commands in react sample app Jun 10, 2022
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🎉, this looks great!

@AgentEnder AgentEnder merged commit 6e924c8 into nrwl:master Jun 10, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants