Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): preset should use packages folder #10691

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

TS preset generates a packages folder, but first package generated creates it in libs

Expected Behavior

TS preset generates a packages folder, and created packages are generated in packages

Context

TS preset used to extend nx/presets/core.json, but we don't do that anymore. When we moved away from that, the preset wasn't updated to generate workspaceLayout

Related Issue(s)

Fixes #10687

@nx-cloud
Copy link

nx-cloud bot commented Jun 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8986771. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 4:47PM (UTC)

@AgentEnder AgentEnder merged commit 6132ad7 into nrwl:master Jun 10, 2022
@AgentEnder AgentEnder deleted the fix/ts/preset-should-use-packages branch June 10, 2022 17:25
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/js:lib generates the package in libs folder instead of packages in ts preset
1 participant