Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fixes Next JS Component generator to export component when 'export' flag is provided #10699

Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jun 10, 2022

Current Behavior

Nothing happens to the library index.ts when --export is provided to the @nrwl/next:component generator

Expected Behavior

mylib/src/index.ts should be updated to export the new component when created with --export

Related Issue(s)

Fixes #
#10322

@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 10, 2022 at 9:17PM (UTC)

@ndcunningham ndcunningham requested a review from jaysoo June 10, 2022 21:16
@jaysoo jaysoo merged commit 550b185 into nrwl:master Jun 13, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants