fix(core): fix ignore logic and un-expose the functions from devkit #10703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
createIgnore, createIgnoreFromTree
are exposed via@nrwl/devkit
but they depend on 3rd party APIs.ignore files at the root are not processed correctly leading to improper ignore checks.
Expected Behavior
createIgnore, createIgnoreFromTree
are not exposed via@nrwl/devkit
yet. We may expose a way to get patterns but we don't want the public API of@nrwl/devkit
to assumeignore
being used.Ignore files at the root are processed properly.
Related Issue(s)
Fixes #