Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects in directories that start with a dot ('.') are not found #10724

Closed
jonathanmorley opened this issue Jun 13, 2022 · 4 comments · Fixed by #10726
Closed

Projects in directories that start with a dot ('.') are not found #10724

jonathanmorley opened this issue Jun 13, 2022 · 4 comments · Fixed by #10726
Labels

Comments

@jonathanmorley
Copy link
Contributor

Current Behavior

Use nx with project auto-detection, and a .foo/package.json file. The project does not show up as an NX project

Expected Behavior

The project should show up in nx graph

Steps to Reproduce

See 'Current Behavior' above

Failure Logs

Environment

NX Report complete - copy this into the issue template

Node : 16.13.1
OS : darwin x64
pnpm : 6.27.1

nx : 14.1.8
@nrwl/angular : Not Found
@nrwl/cypress : Not Found
@nrwl/detox : Not Found
@nrwl/devkit : Not Found
@nrwl/eslint-plugin-nx : Not Found
@nrwl/express : Not Found
@nrwl/jest : Not Found
@nrwl/js : Not Found
@nrwl/linter : Not Found
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/nx-cloud : Not Found
@nrwl/nx-plugin : Not Found
@nrwl/react : Not Found
@nrwl/react-native : Not Found
@nrwl/schematics : Not Found
@nrwl/storybook : Not Found
@nrwl/web : Not Found
@nrwl/workspace : Not Found
typescript : 4.7.2

Community plugins:

@jonathanmorley
Copy link
Contributor Author

This usage of fast-glob (https://github.com/nrwl/nx/blob/master/packages/nx/src/config/workspaces.ts#L584-L588) does not specify the dot option, which means it defaults to false (see https://www.npmjs.com/package/fast-glob#user-content-dot).

@jonathanmorley
Copy link
Contributor Author

Example use-case for needing dot-prefixed directories (pre-empting the question):
We have a monorepo containing github actions, and github actions workflows for use across the organization. It is useful to be able to model these as nx projects.
Github actions workflows must live in a .github/workflows directory, but nx will not recognise package.jsons in the .github directory

@AgentEnder
Copy link
Member

Yeah, that makes sense 👍. Want to open a PR to add it?

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants