feat(react): add generateExportsField option to @nrwl/web:rollup executor so it is an opt-in feature
#10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI is running for commit da947e1. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nartc
reviewed
Jun 14, 2022
…ecutor so it is an opt-in feature - Also adds skipTypeField option in case that is causing issues for users - Fixes nrwl#10741
nartc
approved these changes
Jun 15, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
exportsfield is a way to specify entry points for packages. Node and TypeScript both support this field, however it is causing issues with other tooling, so for now it is opt-in via thegenerateExportsFieldoption.Also adds skipTypeField option in case that is causing issues for users.
Current Behavior
Building with
@nrwl/web:rollupgenerates package.json withexportsfield for the main entry point. This is causing some issues with other tooling/bundlers.Expected Behavior
Users must set
generateExportsField: truein order to generate this field. By default it is off.Related Issue(s)
Fixes #10741