Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): remove unnecessary unused entry module import from new mf remote apps #10749

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Newly generated MF remote apps have an unused import to the remote entry module in the app.module.ts. This is no longer needed because the app.module.ts is set up with a route that lazy loads the remote entry module.

Expected Behavior

Newly generated MF remote apps should not have an unused import to the remote entry module in the app.module.ts.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jun 15, 2022
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 15, 2022 at 11:32AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 25b2682 into nrwl:master Jun 15, 2022
@leosvelperez leosvelperez deleted the angular/improve-mf-remote-generator branch June 15, 2022 13:00
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants