Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep-graph): Fixed graph calculation when there are mixed targets #11418

Merged

Conversation

JakeGinnivan
Copy link
Contributor

Current Behavior

If there is a default target configuration with params: 'forward' and a different target which doesn't have that option you can end up with tasks which do not have the param forwarded.

Expected Behavior

If there is configuration to forward params, they should be forwarded

Related Issue(s)

Extends fix of #11103

@vercel
Copy link

vercel bot commented Aug 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ❌ Failed (Inspect) Oct 27, 2022 at 9:18PM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit edd1415 into nrwl:master Oct 27, 2022
@JakeGinnivan JakeGinnivan deleted the fix/graph-calculation-with-mixed-targets branch December 8, 2022 05:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants