Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): cypress 10 migration supports more configuration setups #12036

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

  1. when running on windows, the paths are not unix normalized missing import changes
  2. when sharing configurations, migration stops after first project
  3. null ref error when running without a cypressConfig in the default executor options
  4. configurations cypressConfig options not getting updated.

Expected Behavior

^^ those things work

Note: when migrating a set up with a shared configuration file and using .env files to change cypress args per project, the migration will not read the .env files. it will only read the shared cypress.json file. In this case you will still need to manually update the paths in the .env file. The migration should still successfully complete assuming appropriate paths within the shared cypress.json file such as supportFile and integrationFolder.

Related Issue(s)

Fixes #11454 #11802

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Sep 15, 2022
@barbados-clemens barbados-clemens self-assigned this Sep 15, 2022
@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 3:43PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
2 participants