Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): specify return type in withNx plugin #12486

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

G07cha
Copy link
Contributor

@G07cha G07cha commented Oct 10, 2022

Current Behavior

Inherited type doesn't exactly match NextConfig causing type-errors when used in combination with other plugins

Expected Behavior

withNx returns valid NextConfig

Related Issue(s)

None

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 10, 2022 at 9:44AM (UTC)

Inherited type doesn't exactly match NextConfig causing type-errors when used in combination with other plugins
@jaysoo
Copy link
Member

jaysoo commented Oct 26, 2022

Looks good, thanks

@jaysoo jaysoo merged commit 94edbe9 into nrwl:master Oct 26, 2022
@G07cha G07cha deleted the fix/next/with-nx-return-type branch October 27, 2022 07:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants