Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): use @swc/jest if being used as transformer #12614

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Oct 14, 2022

Current Behavior

always using babel-jest then swc/jest even if tests where using babel-jest.
babel-jest not calling createTransformer()

Expected Behavior

use swc/jest when the tests are configured for swc/jest
when using babel-jest correctly call the transformer

Related Issue(s)

Fixes #11836
Fixes #12723

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Oct 14, 2022
@barbados-clemens barbados-clemens self-assigned this Oct 14, 2022
@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 21, 2022 at 4:36PM (UTC)

@neil-hughes
Copy link

Hi! I'm not sure of the etiquette here but is there anything I can do to help get this fix merged? Our CI is currently blocked as all tests are failing due to the change in transformer API. Ping me if I can be of any service.

@danr-za
Copy link
Contributor

danr-za commented Oct 27, 2022

Same as the above ❤️

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barbados-clemens barbados-clemens merged commit f3515e4 into nrwl:master Oct 28, 2022
@barbados-clemens barbados-clemens deleted the fix/react-jest-transformer-usage branch October 28, 2022 15:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
4 participants