-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): use @swc/jest if being used as transformer #12614
fix(testing): use @swc/jest if being used as transformer #12614
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
3663891
to
9d7bd87
Compare
9d7bd87
to
8d5a3b8
Compare
8d5a3b8
to
f22dde4
Compare
Hi! I'm not sure of the etiquette here but is there anything I can do to help get this fix merged? Our CI is currently blocked as all tests are failing due to the change in transformer API. Ping me if I can be of any service. |
Same as the above ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
always using babel-jest then swc/jest even if tests where using babel-jest.
babel-jest not calling
createTransformer()
Expected Behavior
use swc/jest when the tests are configured for swc/jest
when using babel-jest correctly call the transformer
Related Issue(s)
Fixes #11836
Fixes #12723