-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): catch rejected promises in convertNxExecutor #12627
fix(core): catch rejected promises in convertNxExecutor #12627
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.catch((err) => { | ||
subscriber.error(err); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR got hard to read because of formatting, this block is the important bit.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
If an Nx executor when wrapped as an Angular builder, errors are not caught causing the builder to hang.
This is demonstrated in this repo: https://github.com/philipjfulcher/angular-builder-uncaught-rejection
After cloning and running
npm i
, trynpx nx allof-run-commands-fails app
to see the uncaught promise rejection error. The process will not close on its own.Expected Behavior
If an Nx executor when wrapped as an Angular builder, errors are caught and report failure successfully.