Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): add button to toggle graph rankDir under feature flag #12646

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

dustyhorizon
Copy link
Contributor

@dustyhorizon dustyhorizon commented Oct 15, 2022

Current Behavior

There is no way to toggle graph layout (rankDir) between TB and LR dependency graph.

Expected Behavior

A button to toggle graph layout (rankDir) between TB and LR on the dependency graph.

Fixes #9995

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 8:23PM (UTC)

@philipjfulcher
Copy link
Collaborator

@dustyhorizon - Thank you for your contribution! Sorry for the delay in reviewing, this came in right before Nx Conf and I'm still catching up.

There are a lot of unexpected commits and file changes as part of this PR. Could you try rebasing on master so that I only see your changes?

allows toggling of graph layout direction via rankDir

ISSUES CLOSED: nrwl#9995
@dustyhorizon
Copy link
Contributor Author

@philipjfulcher not sure what happened when i was resetting my branch to master, had some booboos along the way but seems like the PR autoclosed, should be working now!

@philipjfulcher
Copy link
Collaborator

I think this looks good for the most part, but I have some refactor work in-flight that will cause problems with this addition. We're moving some functionality into the header where you've placed the button so there won't be enough room. I can fix those problems myself, but I've wrapped this button in a feature flag so it's not visible quite yet. I'll re-enable once the refactor is in place. Should hopefully see release in November.

Again, thanks for your work!

@philipjfulcher philipjfulcher changed the title feat(graph): add button to toggle graph rankDir feat(graph): add button to toggle graph rankDir under feature flag Nov 1, 2022
@philipjfulcher philipjfulcher enabled auto-merge (squash) November 1, 2022 20:24
@philipjfulcher philipjfulcher merged commit 5577bfb into nrwl:master Nov 1, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to specify rankDir on cli for graph
2 participants