-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): add button to toggle graph rankDir under feature flag #12646
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dustyhorizon - Thank you for your contribution! Sorry for the delay in reviewing, this came in right before Nx Conf and I'm still catching up. There are a lot of unexpected commits and file changes as part of this PR. Could you try rebasing on |
83440bb
to
3c65b02
Compare
allows toggling of graph layout direction via rankDir ISSUES CLOSED: nrwl#9995
@philipjfulcher not sure what happened when i was resetting my branch to master, had some booboos along the way but seems like the PR autoclosed, should be working now! |
I think this looks good for the most part, but I have some refactor work in-flight that will cause problems with this addition. We're moving some functionality into the header where you've placed the button so there won't be enough room. I can fix those problems myself, but I've wrapped this button in a feature flag so it's not visible quite yet. I'll re-enable once the refactor is in place. Should hopefully see release in November. Again, thanks for your work! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
There is no way to toggle graph layout (rankDir) between
TB
andLR
dependency graph.Expected Behavior
A button to toggle graph layout (rankDir) between
TB
andLR
on the dependency graph.Fixes #9995