-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devkit): names fn constantName #12683
fix(devkit): names fn constantName #12683
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
expect(names('[fooBar]').constantName).toEqual('FOO_BAR'); | ||
expect(names('[...fooBar]').constantName).toEqual('FOO_BAR'); | ||
expect(names('foo-@bar').constantName).toEqual('FOO_BAR'); | ||
expect(names(' foo bar').constantName).toEqual('FOO_BAR'); | ||
expect(names('_foo_bar').constantName).toEqual('FOO_BAR'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These expectations should probably match more closely, the ones for file names and class names.
f809ad2
to
8b37733
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
#12681