Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): names fn constantName #12683

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ApplY3D
Copy link
Contributor

@ApplY3D ApplY3D commented Oct 18, 2022

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 21, 2022 at 11:29PM (UTC)

Comment on lines +41 to +49
expect(names('[fooBar]').constantName).toEqual('FOO_BAR');
expect(names('[...fooBar]').constantName).toEqual('FOO_BAR');
expect(names('foo-@bar').constantName).toEqual('FOO_BAR');
expect(names(' foo bar').constantName).toEqual('FOO_BAR');
expect(names('_foo_bar').constantName).toEqual('FOO_BAR');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These expectations should probably match more closely, the ones for file names and class names.

@FrozenPandaz FrozenPandaz merged commit e584882 into nrwl:master Oct 26, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants