Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): support routes as route array type for ast parsing #12707 #12829

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 26, 2022

Current Behavior

When adding routes to a route constant, we only look for Route[] but Routes is also a valid type

Expected Behavior

Support Routes in AST parsing.

Related Issue(s)

Fixes #12707

@Coly010 Coly010 self-assigned this Oct 26, 2022
@vercel
Copy link

vercel bot commented Oct 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 26, 2022 at 9:26AM (UTC)

@Coly010 Coly010 merged commit d34dff1 into nrwl:master Oct 26, 2022
@Coly010 Coly010 deleted the 12707-support-routes-for-ast branch October 26, 2022 09:49
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing file (apps/host/src/app/app.routes.ts) does not a routing configuration when generating new remote
1 participant