Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): update tsconfig.cy.json template file for generator #12849

Merged

Conversation

rathpc
Copy link
Contributor

@rathpc rathpc commented Oct 27, 2022

Summary

This updates the cypress component project generator to properly use the offset from root to generate the outDir field in the tsconfig.cy.json file that is created rather than a potentially incorrect static offset value.

Current Behavior

outDir always outputs as "outDir": "../../../dist/out-tsc",

Expected Behavior

outDir should use a template variable to offset from the root relative to the project you are running the generator for

Related Issue(s)

Fixes #12846

This updates the cypress component project generator to properly use the offset from
root to generate the outDir field in the tsconfig.cy.json file that is created rather than a
potentially incorrect static offset value.

Fixes nrwl#12846
@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 27, 2022 at 1:56PM (UTC)

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you! :)

@FrozenPandaz FrozenPandaz merged commit cc55cff into nrwl:master Oct 27, 2022
@rathpc rathpc deleted the rathpc/fix-cypress-component-project branch November 15, 2022 00:22
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress component testing tsconfig outDir is not dynamic in the template file
3 participants