-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundling): add support only bundling in workspace libs, not npm packages #12852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 27, 2022 15:36
27c1e84
to
8aba148
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 27, 2022 17:40
8aba148
to
c250753
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 27, 2022 19:46
c250753
to
54444ea
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 01:26
54444ea
to
52fd6d8
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 01:33
52fd6d8
to
8b17314
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 01:46
8b17314
to
2ecdb82
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 01:53
2ecdb82
to
a1e3c57
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 02:17
a1e3c57
to
c082c98
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 03:22
c082c98
to
bf302d6
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 12:25
bf302d6
to
21eb61d
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 12:42
21eb61d
to
a4f50a7
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 13:30
a4f50a7
to
fbf5a45
Compare
jaysoo
force-pushed
the
feat/esbuild-bundle-workspace-libs
branch
from
October 28, 2022 14:16
fbf5a45
to
3c2a634
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to pass the
--no-third-party
option (or--third-party=no
), so the generated bundled will include all workspace libs but exclude third-party packages.Why?
This is useful for Docker images, publishing to npm, etc. where you expect third-party packages to be installed via
npm i
(oryarn
orpnpm i
).Alternatives
The workaround currently is to pass a fixed
--external
list (e.g.--external=rambda,dayjs,chalk,uuid
), which will exclude those packages in the bundle. The--no-third-party
option will automatically mark these as external, and include them in the generatedpackage.json
file.Current Behavior
Bundle includes everything -- unless in
--external
list.Expected Behavior
Bundle only includes libs/packages in the workspace.
Related Issue(s)
Fixes #