Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add webpack-server builder with support for custom webpack config #12917

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 1, 2022

Current Behavior

We do not offer a builder/executor for using a custom webpack config with Angular Universal.

Expected Behavior

Add an executor to support this.

@Coly010 Coly010 self-assigned this Nov 1, 2022
@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 3:46PM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Just left one last minor cleanup comment, but it's non-blocking.

@Coly010 Coly010 merged commit a5d0314 into nrwl:master Nov 1, 2022
@Coly010 Coly010 deleted the angular/custom-webpack-server branch November 1, 2022 16:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants