Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): report should not include non-plugin packages as local plugins #18306

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

nx report can occasionally include packages which are not plugins

Expected Behavior

nx report is faster and only includes actual plugins

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner July 25, 2023 16:12
@AgentEnder AgentEnder requested a review from vsavkin July 25, 2023 16:12
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 3:46pm


export async function getLocalWorkspacePlugins(
projectsConfiguration: ProjectsConfigurations
projectsConfiguration: ProjectsConfigurations,
nxJson: NxJsonConfiguration = readNxJson()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this default

@AgentEnder AgentEnder force-pushed the fix/report-shouldnt-include-nonplugins branch from fa06dca to f6a181a Compare August 3, 2023 15:43
@AgentEnder AgentEnder merged commit 1861d6e into nrwl:master Aug 3, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants