Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): split devkit reference page #18536

Merged
merged 6 commits into from Aug 10, 2023

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Aug 8, 2023

  • Splits the devkit reference page into many pages (one page per object)
  • Some types that were previously listed only as Object are now actually documented
  • No redirects needed since the entry point pages remain the same
  • The pages for individual types and functions are not listed in map.json so we don't have to manually update that file any time the code changes. The link checker was updated to account for that

Question:
The ngcli_adapter items are nested under ngcli_adapter in the breadcrumbs. Should I do the same thing for devkit? This will add a redirect, but that's not a big deal. I only hesitated to do that because the breadcrumb would be devkit > documents > devkit > someFunction which looks weird.

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 7:07pm

@FrozenPandaz
Copy link
Collaborator

https://nx-dev-git-fork-isaacplmann-docs-split-devkit-reference-nrwl.vercel.app/packages/devkit/documents/ExecutorContext#target

Is it possible to get the type information in the table of contents as well? I think it would be helpful to see all the types in a single fold. Most of them are hopefully self explanatory once the reader knows the type so they don't have to click to find out the type of the property.

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than before. I agree with Jason's comment, maybe enriching the TOC with some further info could be helpful.

Also, I get this is ref docs, but I'm wondering whether it would make sense to categorize the TOC not based on the type (which I understand can be done automatically right now), but rather categorize by when you'd need them. Like working with files, project config, templating,... Just a thought 🤔

@isaacplmann
Copy link
Collaborator Author

I'll merge this and make a follow up PR with improvements

@isaacplmann isaacplmann merged commit da2ca3a into nrwl:master Aug 10, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants