Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): ai chat ui improvements #18560

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 10, 2023

@mandarini mandarini requested a review from a team as a code owner August 10, 2023 08:52
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 9:16am

@mandarini mandarini self-assigned this Aug 10, 2023
@@ -54,8 +54,8 @@ export function FeatureAi(): JSX.Element {
sourcesMarkdown = aiResponse.sourcesMarkdown;

setLoading(false);
} catch (error) {
setError(error as any);
} catch (error: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not:

Suggested change
} catch (error: any) {
} catch (error: Error) {

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise LGTM

@meeroslav meeroslav merged commit aa9eaa7 into nrwl:master Aug 10, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
@mandarini mandarini deleted the fix/chat-ui-fixes branch August 22, 2023 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants