feat(core): create function to transform project graph between js and… #18578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
project-graph-transfer
branch
from
76470ee
to
ba854d9
Compare
Cammisuli
reviewed
Aug 11, 2023
Comment on lines
17
to
28
| // type ExpandedSelfInput = | ||
| // | { fileset: string } | ||
| // | { runtime: string } | ||
| // | { env: string } | ||
| // | { externalDependencies: string[] }; | ||
| // | ||
| // type ExpandedDepsOutput = { | ||
| // dependentTasksOutputFiles: string; | ||
| // transitive?: boolean; | ||
| // }; | ||
| // | ||
| // type ExpandedInput = ExpandedSelfInput | ExpandedDepsOutput; |
There was a problem hiding this comment.
I know this was used as a placeholder to do the conversion to rust, I can remove it later, or you can do it now 😄
FrozenPandaz
force-pushed
the
project-graph-transfer
branch
from
ba854d9
to
aed6757
Compare
Cammisuli
approved these changes
Aug 11, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… rust
Current Behavior
Transferring the project graph takes roughly 42ms
Expected Behavior
Transferring the project graph takes roughly 14ms (on my machine)
This isn't used yet. So nothing really changes
Related Issue(s)
Fixes #