Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): install nx/vite for non-buildable libs #18778

Merged
merged 1 commit into from Aug 22, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 22, 2023

closed #18682

Current Behavior

#18682 (comment)

If a user sets up Storybook for a library that's not buildable, and they get the @storybook/react-vite builder (or any other Storybook vite builder), the library does not have a vite.config file, so the tsconfig paths are not registered.

Expected Behavior

For non-buildable libraries that use the @storybook/react-vite builder (or any other Storybook vite builder), install the @nx/vite plugin and use the nxViteTsPaths plugin to register the paths correctly.

Related Issue(s)

Fixes #18682

@mandarini mandarini requested a review from a team as a code owner August 22, 2023 15:59
@mandarini mandarini requested a review from Coly010 August 22, 2023 15:59
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 4:09pm

@mandarini mandarini self-assigned this Aug 22, 2023
@mandarini mandarini requested a review from a team as a code owner August 22, 2023 15:59
@mandarini mandarini merged commit 57463ed into nrwl:master Aug 22, 2023
15 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 23, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook with vite configuration cannot resolve local libraries
3 participants