Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): buildable libs should lint correctly #18802 #18837

Merged
merged 1 commit into from Aug 25, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 25, 2023

Current Behavior

Creating a buildable library in angular creates a setup that fails nx lint.

Expected Behavior

Creating a buildable library in angular should create a setup that does not fail nx lint

Notes

There is more work to do here.
Angular projects do not set up the dependency checks eslint rule. We need to figure out the best approach to adding this support across both the angular package and linter package.

Related Issue(s)

Fixes #18802

@Coly010 Coly010 requested a review from a team as a code owner August 25, 2023 11:11
@Coly010 Coly010 self-assigned this Aug 25, 2023
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 0:30am

@Coly010 Coly010 merged commit 889f315 into nrwl:master Aug 25, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint fails on angular buildable libraries
2 participants