Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): handle nested wildcard imports and paths that start with # #19056

Merged
merged 1 commit into from Sep 7, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Imports which that start with # do not get processed properly.

Imports which use a wildcard in tsconfig.json which actually traverse into a child project were identified as imports for the parent project.

Expected Behavior

Imports which that start with # do get processed properly.

Imports which use a wildcard in tsconfig.json which actually traverse into a child project are identified as imports for the child project.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner September 7, 2023 17:20
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 5:21pm

@FrozenPandaz FrozenPandaz merged commit 4b344ac into nrwl:master Sep 7, 2023
12 of 15 checks passed
@FrozenPandaz FrozenPandaz deleted the import-locator-fix branch September 7, 2023 20:07
FrozenPandaz added a commit that referenced this pull request Sep 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants