-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Module federation dev server does not calculate shared dependencies correctly when multiple dev remotes are used. #21391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@statop Thanks for raising this! Would it be possible for you to create a minimal repo that reproduces this issue? I'm not exactly sure what you mean by "not correctly shared". I have an idea on how to potentially fix this but I'm not sure how to test it because I don't know exactly what is incorrect here. |
Added a comment to your pr. If you fix that it will probably fix this bug. I don't really have time to create a repro. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
Module federation dev server does not calculate shared dependencies correctly when multiple dev remotes are used.
Expected Behavior
Module federation dev server does calculates shared dependencies correctly when multiple dev remotes are used.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
pnpm 8.14.3
Operating System
Additional Information
The core problem is the caching of ts path mappings in here https://github.com/nrwl/nx/blob/master/packages/webpack/src/utils/module-federation/typescript.ts#L7
That can cause the calculated path of one project to be used for a totally separate project when they are run in the same process.
The text was updated successfully, but these errors were encountered: