Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library schematics outputs misleading info about "UPDATE package.json" #2317

Closed
4 tasks done
Tracked by #1
Hotell opened this issue Jan 15, 2020 · 1 comment · Fixed by #2332
Closed
4 tasks done
Tracked by #1

library schematics outputs misleading info about "UPDATE package.json" #2317

Hotell opened this issue Jan 15, 2020 · 1 comment · Fixed by #2332
Assignees

Comments

@Hotell
Copy link
Contributor

Hotell commented Jan 15, 2020

Prerequisites

  • I am running the latest version
  • I checked the documentation (nx.dev) and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (not related to React, Angular or any dependency)

Expected Behavior

Schematics should give user correct info what was changed/created/deleted

Current Behavior

running library schematics (workspace/react/node) says in output that package.json was UPDATED although it was not. I was not able to find any code touching package.json within those schematics generators.

So I assume this output might be coming from @angular-devkit/schematics package ?

image

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. yarn nx g @nrwl/workspace:lib hello-world --dryRun
  2. see output

Context

Please provide any relevant information about your setup:

  @nrwl/angular : Not Found
  @nrwl/cli : 8.11.0
  @nrwl/cypress : 8.11.0
  @nrwl/eslint-plugin-nx : 8.11.0
  @nrwl/express : Not Found
  @nrwl/jest : 8.11.0
  @nrwl/linter : 8.11.0
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : 8.11.0
  @nrwl/react : 8.11.0
  @nrwl/schematics : Not Found
  @nrwl/tao : 8.11.0
  @nrwl/web : 8.11.0
  @nrwl/workspace : 8.11.0
  typescript : 3.7.2
@Hotell Hotell changed the title library schematics misleading output about UPDATE package.json library schematics outputs misleading info about "UPDATE package.json" Jan 15, 2020
@juristr juristr self-assigned this Jan 16, 2020
juristr added a commit to juristr/nx that referenced this issue Jan 17, 2020
Adjusts the schematic to only touch the package.json if really required

ISSUES CLOSED: nrwl#2317
juristr added a commit to juristr/nx that referenced this issue Jan 21, 2020
Adjusts the schematic to only touch the package.json if really required

ISSUES CLOSED: nrwl#2317
juristr added a commit to juristr/nx that referenced this issue Jan 27, 2020
Adjusts the schematic to only touch the package.json if really required

ISSUES CLOSED: nrwl#2317
juristr added a commit to juristr/nx that referenced this issue Jan 27, 2020
Adjusts the schematic to only touch the package.json if really required

ISSUES CLOSED: nrwl#2317
FrozenPandaz pushed a commit that referenced this issue Jan 29, 2020
Adjusts the schematic to only touch the package.json if really required

ISSUES CLOSED: #2317
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants