Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): remove ng module import from angular stories #2399

Merged
merged 1 commit into from Jan 30, 2020

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior (This is the behavior we have today, before the PR is merged)

The ngModule imports was removed but the import is still there.

Expected Behavior (This is the new behavior we can expect after the PR is merged)

The import is now removed as well.

Issue

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should remove that ngModule import. I originally put it there in an attempt to automatically include the dependencies that a particular component will need, but the use cases got too complicated for me to try to automate that.

@FrozenPandaz FrozenPandaz merged commit 05dbcef into nrwl:master Jan 30, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants