Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): add update-playground script #2433

Merged
merged 1 commit into from Feb 5, 2020

Conversation

rarmatei
Copy link
Collaborator

@rarmatei rarmatei commented Feb 5, 2020

After creating a new playground, you can now run yarn update-playground to update with the latest
changes to NX without deleting and recreating the whole playground

Current Behavior (This is the behavior we have today, before the PR is merged)

To update the playground you'd need to call the yarn copy script and pass it the full folder path for each playground project.

Expected Behavior (This is the new behavior we can expect after the PR is merged)

There is now a quick script yarn update-playground that builds and copies the artefacts in both the nx and angular playground projects.

After creating a new playground, you can now run `yarn update-playground` to update with the latest
changes to NX without deleting and recreating the whole playground
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At first I thought you should re-use the copy.sh script, but I see that that would execute the build twice.

@juristr
Copy link
Member

juristr commented Feb 5, 2020

Oh that's cool. I actually saw that behavior and thought something like this would be useful to add. Thx Rares 🙂

@rarmatei rarmatei merged commit 305cd42 into nrwl:master Feb 5, 2020
@rarmatei rarmatei deleted the update-playground branch February 5, 2020 15:26
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants