Skip to content

Module Federation not working without barrel imports? #26765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
aswarcewicz opened this issue Jun 29, 2024 · 1 comment · Fixed by #27149
Closed
1 of 4 tasks

Module Federation not working without barrel imports? #26765

aswarcewicz opened this issue Jun 29, 2024 · 1 comment · Fixed by #27149
Assignees
Labels
outdated scope: module federation Issues related to module federation support type: bug

Comments

@aswarcewicz
Copy link

Current Behavior

When I removed barrel imports (index.ts) from tsconfig.base.json and replace it by asterisk I got errors Error: Module not found: Error: Can't resolve '@ng-mf/my-button/*' in

Expected Behavior

No errors when compiling without barrel imports

GitHub Repo

https://github.com/aswarcewicz/nx-ng-dyn-fed/blob/no-barrel-imports-tests/tsconfig.base.json

Steps to Reproduce

  1. Clone repository https://github.com/aswarcewicz/nx-ng-dyn-fed
  2. switch to branch no-barrel-imports-tests
  3. run npx nx serve dashboard
  4. In console you get Error: Module not found: Error: Can't resolve '@ng-mf/my-button/*' in '...'

Nx Report

Node   : 20.12.2
OS     : linux-x64
yarn   : 1.22.22

nx (global)        : 18.3.4
nx                 : 18.2.3
@nx/js             : 18.2.3
@nx/jest           : 18.2.3
@nx/linter         : 18.2.3
@nx/eslint         : 18.2.3
@nx/workspace      : 18.2.3
@nx/angular        : 18.2.3
@nx/cypress        : 18.2.3
@nx/devkit         : 18.2.3
@nx/eslint-plugin  : 18.2.3
@nrwl/tao          : 18.2.3
@nx/web            : 18.2.3
@nx/webpack        : 18.2.3
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/cypress/plugin
@nx/eslint/plugin

Failure Logs

Error: Module not found: Error: Can't resolve '@ng-mf/my-button/*' in '...'

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

When barrel file is used (index.ts) in tsconfig.base.json like below:
"paths": { ... "@ng-mf/my-button": ["libs/shared/my-button/src/index.ts"],
Everything works as expected

@AgentEnder AgentEnder added the scope: module federation Issues related to module federation support label Jul 8, 2024
Coly010 added a commit that referenced this issue Jul 26, 2024
Coly010 added a commit that referenced this issue Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Coly010 added a commit that referenced this issue Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Coly010 added a commit that referenced this issue Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Coly010 added a commit that referenced this issue Jul 26, 2024
#27149)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Module Federation setups using `/*` wildcards in ts path mappings error
out as they cannot resolve the module.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
`/*` ts path mappings should still allow modules to be resolved

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26765
FrozenPandaz pushed a commit that referenced this issue Jul 30, 2024
#27149)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Module Federation setups using `/*` wildcards in ts path mappings error
out as they cannot resolve the module.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
`/*` ts path mappings should still allow modules to be resolved

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26765

(cherry picked from commit 38a7f43)
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: module federation Issues related to module federation support type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants