-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Module Federation not working without barrel imports? #26765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Coly010
added a commit
that referenced
this issue
Jul 26, 2024
Loading
Loading status checks…
#27149) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Module Federation setups using `/*` wildcards in ts path mappings error out as they cannot resolve the module. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `/*` ts path mappings should still allow modules to be resolved ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26765
FrozenPandaz
pushed a commit
that referenced
this issue
Jul 30, 2024
#27149) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Module Federation setups using `/*` wildcards in ts path mappings error out as they cannot resolve the module. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `/*` ts path mappings should still allow modules to be resolved ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26765 (cherry picked from commit 38a7f43)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Current Behavior
When I removed barrel imports (index.ts) from tsconfig.base.json and replace it by asterisk I got errors Error:
Module not found: Error: Can't resolve '@ng-mf/my-button/*' in
Expected Behavior
No errors when compiling without barrel imports
GitHub Repo
https://github.com/aswarcewicz/nx-ng-dyn-fed/blob/no-barrel-imports-tests/tsconfig.base.json
Steps to Reproduce
no-barrel-imports-tests
npx nx serve dashboard
Error: Module not found: Error: Can't resolve '@ng-mf/my-button/*' in '...'
Nx Report
Failure Logs
Package Manager Version
No response
Operating System
Additional Information
When barrel file is used (index.ts) in tsconfig.base.json like below:
"paths": { ... "@ng-mf/my-button": ["libs/shared/my-button/src/index.ts"],
Everything works as expected
The text was updated successfully, but these errors were encountered: