You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@nx/vite/plugin will only create serve target on a vite project when there is not a build.lib target, even if there is a serve config present in the vite.config.ts. This change was introduced by #26420
Expected Behavior
@nx/vite/plugin infers correctly that the project has a serve target, and thus create them on the graph
…27370 (#27507)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->
## Current Behavior
<!-- This is the behavior we have today -->
Vite Plugin was originally only checking if the `lib` option was defined
in a vite config, and using that to avoid inferring serve targets.
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Some libraries may still need a serve target, and if they have a server
config defined, the serve target should be inferred
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#27370
(cherry picked from commit 08fc13d)
Current Behavior
@nx/vite/plugin
will only create serve target on a vite project when there is not a build.lib target, even if there is a serve config present in thevite.config.ts
. This change was introduced by #26420Expected Behavior
@nx/vite/plugin
infers correctly that the project has a serve target, and thus create them on the graphGitHub Repo
https://github.com/beaussan/repro-vite-lib-serve
Steps to Reproduce
@nx/react:library
for exNx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
I see two way to fix the issue:
The text was updated successfully, but these errors were encountered: