Skip to content

@nrwl/react:app/lib and @nrwl/express:app/lib should fail if name isn't supplied #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catfireparty opened this issue Apr 27, 2020 · 2 comments · Fixed by #3396
Closed
Labels
community This is a good first issue for contributing outdated type: bug

Comments

@catfireparty
Copy link
Contributor

From here: #333 (comment)

Both nx g @nrwl/express:app/lib and nx g @nrwl/react:app/lib create files in the root of /apps//libs if the user does not provide an application name.

These schematics should fail with an error if the name is empty.

This should be a matter of either validating the options/schema before running any of the following rules, or possibly just adding a regex which will fail if the input is empty (note that libs starting with numbers would also be invalid, so something like ^[a-zA-Z]{1}.*$ might suffice.

@catfireparty catfireparty added type: bug community This is a good first issue for contributing labels Apr 27, 2020
@cristianmartinez
Copy link
Contributor

Is someone working on this? @jdpearce can I take it?

FrozenPandaz pushed a commit that referenced this issue Jul 31, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…reation (#3396)

ISSUES CLOSED: #2924
FrozenPandaz pushed a commit that referenced this issue Aug 13, 2020
FrozenPandaz pushed a commit that referenced this issue Aug 13, 2020
Doginal pushed a commit to Doginal/nx that referenced this issue Nov 25, 2020
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community This is a good first issue for contributing outdated type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants