Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): properly resolve tsconfig when serving from project root #3403

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Running ng serve from an app's directory will not generate the right path for the generated tmp tsconfig.

Expected Behavior

Running ng serve from an app's directory will generate the right path for the generated tmp tsconfig.

Related Issue(s)

Fixes #3316

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@FrozenPandaz FrozenPandaz changed the title fix(core): pass absolute path to tsconfig to build-utils fix(core): properly resolve tsconfig when serving from project root Jul 24, 2020
@FrozenPandaz FrozenPandaz merged commit 7af13bb into nrwl:master Jul 31, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express up is not able to run/be build from non root folders
1 participant