Skip to content

fix(core): improve performance of analyzing npm dependencies #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2020
Merged

fix(core): improve performance of analyzing npm dependencies #3755

merged 1 commit into from
Sep 19, 2020
+17 −13

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Finding npm dependencies from imports in a large workspace takes ~4.2s
Overall Project Graph creation time took 18s

Expected Behavior

Finding npm dependencies from imports in a large workspace takes ~.325s
Overall Project Graph creation time took 15s

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from jaysoo September 17, 2020 17:48
@nx-cloud
Copy link

nx-cloud bot commented Sep 17, 2020 •
edited
Loading

Nx Cloud Report

CI ran the following commands. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base angular 9/18/2020, 5:43:28 PM
#000000 nx build-base create-nx-plugin 9/18/2020, 5:43:34 PM
#000000 nx build-base express 9/18/2020, 5:43:41 PM
#000000 nx build-base nest 9/18/2020, 5:43:41 PM
#000000 nx build-base next 9/18/2020, 5:43:46 PM
#000000 nx build-base node 9/18/2020, 5:43:28 PM
#000000 nx build-base react 9/18/2020, 5:43:41 PM
#000000 nx build-base storybook 9/18/2020, 5:43:33 PM
#000000 nx build-base web 9/18/2020, 5:43:27 PM
#000000 nx run-many --target=build --all --parallel 9/18/2020, 5:43:06 PM
#000000 nx run-many --target=e2e --projects=e2e-angular,e2e-bazel 9/18/2020, 5:44:14 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest,e2e-nx-plugin 9/18/2020, 5:43:07 PM
#000000 nx run-many --target=e2e --projects=e2e-next 9/18/2020, 5:43:06 PM
#000000 nx run-many --target=e2e --projects=e2e-node 9/18/2020, 5:43:18 PM
#000000 nx run-many --target=e2e --projects=e2e-react 9/18/2020, 5:43:07 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 9/18/2020, 5:43:14 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace,e2e-cli 9/18/2020, 5:43:34 PM
#000000 nx run-many --target=test --all --parallel 9/18/2020, 5:43:08 PM

Sent with 💌 from NxCloud.

@jaysoo jaysoo merged commit 6603889 into nrwl:master Sep 19, 2020
vivekmore pushed a commit to vivekmore/nx that referenced this pull request Sep 19, 2020
@FrozenPandaz @vivekmore
fix(core): improve performance of analyzing npm dependencies (nrwl#3755)
378566e
FrozenPandaz added a commit that referenced this pull request Oct 9, 2020
@FrozenPandaz
fix(core): improve performance of analyzing npm dependencies (#3755)
9c5c5fe
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@FrozenPandaz @Doginal
fix(core): improve performance of analyzing npm dependencies (nrwl#3755)
b66c26b
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FrozenPandaz @jaysoo