Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Misnamed link in sidebar #3762

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix(docs): Misnamed link in sidebar #3762

merged 1 commit into from
Sep 18, 2020

Conversation

ZackDeRose
Copy link
Member

Current Behavior

image

Looks like replace-all mix-up in the map.json for the sidebar tree data.

Expected Behavior

The the first 'node' link in the picture about should be named 'react' (all links still work properly and send user to react docs)

Related Issue(s)

Fixes #

Verified

This commit was signed with the committer’s verified signature.
tri-adam Adam Hughes
@ZackDeRose ZackDeRose self-assigned this Sep 18, 2020
@nx-cloud
Copy link

nx-cloud bot commented Sep 18, 2020

Nx Cloud Report

CI ran the following commands. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 9/18/2020, 5:10:50 AM
#000000 nx run-many --target=e2e --projects=e2e-angular,e2e-bazel 9/18/2020, 5:08:16 AM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest,e2e-nx-plugin 9/18/2020, 5:11:13 AM
#000000 nx run-many --target=e2e --projects=e2e-next 9/18/2020, 5:08:47 AM
#000000 nx run-many --target=e2e --projects=e2e-node 9/18/2020, 5:08:33 AM
#000000 nx run-many --target=e2e --projects=e2e-react 9/18/2020, 5:09:13 AM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 9/18/2020, 5:09:26 AM
#000000 nx run-many --target=e2e --projects=e2e-workspace,e2e-cli 9/18/2020, 5:09:15 AM
#000000 nx run-many --target=test --all --parallel 9/18/2020, 5:08:07 AM

Sent with 💌 from NxCloud.

@bcabanes bcabanes merged commit 231e666 into master Sep 18, 2020
@bcabanes bcabanes deleted the sidebar-fix branch September 18, 2020 13:57
vivekmore pushed a commit to vivekmore/nx that referenced this pull request Sep 19, 2020
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants