Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): npmrc should be obeyed during nx migrate #6781

Merged
merged 1 commit into from Sep 1, 2021

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Aug 19, 2021

Current Behavior

Calling nx migrate 'my-package' does not obey registry settings from .npmrc. This leads to things like trying to pull latest from npm, or yarn registry instead of the registry pointed to by the workspace.

If an enterprise workspace was using a private registry, and had a custom nx plugin, they would not be able to use nx migrate for their internal migration scripts.

Expected Behavior

Registries and authorization headers in .npmrc should be obeyed by nx migrate

Workaround

Setting environment config variables does work, such as export NPM_CONFIG_REGISTRY=...., but these cannot be scoped to certain scopes etc.

@vercel
Copy link

vercel bot commented Aug 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/J7kaxD1n71FsDCXN1hR4uS34Sjzg
✅ Preview: Canceled

[Deployment for a4e2faf canceled]

packages/tao/src/commands/migrate.ts Outdated Show resolved Hide resolved
packages/tao/src/commands/migrate.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor requests

packages/tao/src/commands/migrate.ts Outdated Show resolved Hide resolved
packages/tao/src/commands/migrate.ts Outdated Show resolved Hide resolved
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) September 1, 2021 22:55
@FrozenPandaz FrozenPandaz merged commit b416bb6 into nrwl:master Sep 1, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants