Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): npm dependencies from the project graph #6843

Merged
merged 1 commit into from Sep 2, 2021

Conversation

kazamov
Copy link
Contributor

@kazamov kazamov commented Aug 25, 2021

get the npm dependencies from the project graph correctly. Allow deep import from externals passed from settings

Current Behavior

The npm dependencies are read incorrectly from the project graph. Also, there is no deep analysis of external packages, but they are matched directly by id, but the npm dependencies have this logic.

Expected Behavior

The npm dependencies should be read correctly from the project graph by the project name. externals from the build config should allow nested imports as well as npm packages.

get the npm dependencies from the project graph correctly. Allow deep import from `externals` passed from settings
@vercel
Copy link

vercel bot commented Aug 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4bWeiRaEGPhCipAWeVcbaE449nPp
✅ Preview: Canceled

@kazamov
Copy link
Contributor Author

kazamov commented Aug 25, 2021

@FrozenPandaz, please review. Tell me please, do you have plans to make the umd output optional using some setting?

@jaysoo jaysoo merged commit 804cc73 into nrwl:master Sep 2, 2021
@kazamov kazamov deleted the fix-package-npm-dependencies-retrieval branch September 3, 2021 06:20
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
get the npm dependencies from the project graph correctly. Allow deep import from `externals` passed from settings

Co-authored-by: Zakir Nuriiev <zakir.nuriev@caspio.com>
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants