feat(linter): add support for workspace rules

[JamesHenry]

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4zYEakep3DoVM3r42AgRQ5AesGos
✅ Preview: https://nx-dev-git-fork-jameshenry-nx-local-workspace-lint-rules-nrwl.vercel.app

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 0689800. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=e2e --base=44db568261e93e252d1a89af262c6532e0ce1215
	nx affected --target=lint --base=44db568261e93e252d1a89af262c6532e0ce1215 --parallel --max-parallel=4
	nx affected --target=test --base=44db568261e93e252d1a89af262c6532e0ce1215 --parallel --max-parallel=2
	nx affected --target=build --base=44db568261e93e252d1a89af262c6532e0ce1215 --parallel --max-parallel=3
	nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[FrozenPandaz]

Webstorm doesn't seem to be picking up when I make changes to the local rule 🤔

[mattlewis92]

This is really great to see! Right now we've been writing custom eslint rules as a library, but it's kind of clunky to wire it up to eslint. With this way it doesn't look like there's a way to write tests for custom lint rules though, is this something that could be added? (the same problem exists for writing custom generators)

[JamesHenry]

Thanks @mattlewis92 it's a good call out, most workspaces will want to be able to test their lint rules programmatically as well as manually.

@FrozenPandaz and I discussed it and I have extended the PR to have the eslint-rules be a full project on the project-graph and generate a valid jest test target, as well as generate a spec for every rule that is generated.

[JamesHenry]

Build failing because of #6900, not related to this PR

[mattlewis92]

Thanks @mattlewis92 it's a good call out, most workspaces will want to be able to test their lint rules programmatically as well as manually.

@FrozenPandaz and I discussed it and I have extended the PR to have the eslint-rules be a full project on the project-graph and generate a valid jest test target, as well as generate a spec for every rule that is generated.

Amazing, thank you so much!! 🙌

[FrozenPandaz]

Can we also add an e2e test for this please?

[JamesHenry]

Thanks @FrozenPandaz, ready for another look

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.