Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): normalizing paths when moving files #6877

Merged
merged 1 commit into from Aug 27, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Aug 27, 2021

Current Behavior

The directories passed in to moveDir are not normalized while the file is.

Expected Behavior

moveFilesToNewDirectory works on windows.

Related Issue(s)

Fixes #6795

@vercel
Copy link

vercel bot commented Aug 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6tAuBfbhKiZiC6AuboSbMtfH6Yqx
✅ Preview: Canceled

@FrozenPandaz FrozenPandaz merged commit 12ed2d3 into nrwl:master Aug 27, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@shahggeek
Copy link

Hi Jason @FrozenPandaz
I am using version 12.9.0, but I still see this issue #6795
$npx ng g @nrwl/angular:app tutorials --prefix="tuts" --routing --style="scss"
Cannot read property 'replace' of null

Environment

Node : 14.16.1
OS : win32 x64
npm : 6.14.15

nx : 12.9.0
@nrwl/angular : 12.9.0
@nrwl/cli : 12.9.0
@nrwl/cypress : 12.9.0
@nrwl/devkit : 12.9.0
@nrwl/eslint-plugin-nx : 12.9.0
@nrwl/express : 12.9.0
@nrwl/jest : 12.9.0
@nrwl/linter : 12.9.0
@nrwl/nest : 12.9.0
@nrwl/next : Not Found
@nrwl/node : 12.9.0
@nrwl/nx-cloud : Not Found
@nrwl/react : Not Found
@nrwl/schematics : Not Found
@nrwl/tao : 12.9.0
@nrwl/web : Not Found
@nrwl/workspace : 12.9.0
@nrwl/storybook : 12.9.0
@nrwl/gatsby : Not Found
typescript : 4.3.5

Do you know if Issue #6877 released in 12.9.0 ? Thanks in advance for your help.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate Angular App on Windows
2 participants